[CLD-1924]: fix(deployment): remove ported code to cld-changesets#22188
Open
graham-chainlink wants to merge 1 commit intodevelopfrom
Open
[CLD-1924]: fix(deployment): remove ported code to cld-changesets#22188graham-chainlink wants to merge 1 commit intodevelopfrom
graham-chainlink wants to merge 1 commit intodevelopfrom
Conversation
graham-chainlink
requested review from
AmrMohamedRezk,
KodeyThomas,
agusaldasoro,
asoliman92,
chris-de-leon-cll,
tt-cll and
winder
graham-chainlink
changed the title
product-security-plaid-production
Bot
requested review from
chudilka1,
jkongie and
skudasov
Contributor
|
👋 graham-chainlink, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
CORA - Pending Reviewers
Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM — Removes in-repo changeset implementations and switches callers to a newly added external module (cld-changesets), alongside several dependency bumps across multiple Go modules.
This PR removes Solana and Job Distributor changeset code that has been moved to cld-changesets, updates call sites to use the new module, and refreshes related dependency versions across the repo’s multiple Go modules.
Changes:
- Remove
deployment/common/changeset/solana/helpers.goanddeployment/common/changeset/jobspec.go(ported tocld-changesets). - Update Solana funding changesets and CCIP jobspec integration tests to call
cld-changesetsequivalents. - Bump
chainlink-deployments-framework,chainlink-testing-framework,pgproto3, and addcld-changesetsto relevantgo.mod/go.sumfiles.
Reviewed changes
Copilot reviewed 11 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| system-tests/tests/go.mod | Bumps dependencies; adds cld-changesets indirectly. |
| system-tests/tests/go.sum | Updates sums for bumped deps and new cld-changesets entry. |
| system-tests/lib/go.mod | Bumps dependencies; adds cld-changesets indirectly. |
| system-tests/lib/go.sum | Updates sums for bumped deps and new cld-changesets entry. |
| integration-tests/smoke/ccip/ccip_jobspec_test.go | Switches JD changesets usage to cld-changesets/jd/changesets. |
| integration-tests/load/go.mod | Bumps dependencies to align with the new changeset/module versions. |
| integration-tests/load/go.sum | Updates sums for bumped deps. |
| integration-tests/go.mod | Adds direct dependency on cld-changesets and bumps key deps. |
| integration-tests/go.sum | Updates sums for bumped deps and new cld-changesets entry. |
| deployment/go.mod | Adds direct dependency on cld-changesets and bumps framework/testing deps. |
| deployment/go.sum | Updates sums for bumped deps and new cld-changesets entry. |
| deployment/common/changeset/solana/helpers.go | Removes legacy Solana funding helpers now sourced from cld-changesets. |
| deployment/common/changeset/solana/fund_mcm_pdas.go | Switches funding calls to cld-changesets Solana helpers. |
| deployment/common/changeset/jobspec.go | Removes legacy JD revoke/delete changesets now sourced from cld-changesets. |
| deployment/common/changeset/example/solana_transfer_mcm.go | Switches SOL transfer instruction creation to cld-changesets helper. |
| core/scripts/go.mod | Bumps dependencies; adds cld-changesets indirectly. |
| core/scripts/go.sum | Updates sums for bumped deps and new cld-changesets entry. |
|
|
graham-chainlink
force-pushed
the
ggoh/cld-1924/remove-ported-code
branch
2 times, most recently
from
0213ce3 to
1354429
Compare
Remove solana/helpers.go and jobspec.go as they have been moved over to cld-changesets JIRA: https://smartcontract-it.atlassian.net/browse/CLD-1924
graham-chainlink
force-pushed
the
ggoh/cld-1924/remove-ported-code
branch
from
1354429 to
3b96e6a
Compare
|
ecPablo
approved these changes
Apr 27, 2026
gustavogama-cll
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove solana/helpers.go and jobspec.go as they have been moved over to cld-changesets
JIRA: https://smartcontract-it.atlassian.net/browse/CLD-1924